|Thread Links||Date Links|
|Thread Prev||Thread Next||Thread Index||Date Prev||Date Next||Date Index|
Please see inline ...
On 19/09/2016 09:37, Pauwels, Ludwig (Nokia - BE) wrote:
Technically yes, but I don't 100% agree with everything that Marek added/changed from my previous version (https://github.com/YangModels/yang/blob/3fe7a8c0e1b92cff846a0038cfb92695f5e627f2/experimental/ieee/802.3/ethernet.yang), and I think that it needs some further review and refinement (which I'm happy to help with).
Yes, you are right, this isn't quite right.
Probably the auto-negotation "status" leaf should be moved outside of the choice statement and renamed to "auto-negotiation", status is a bad name anyway.
One key question here is whether the model should define a default value for auto-negotiation. For one class of our devices, it defaults to off unless explicitly configured (due to historical reasons), but IIRC the current 802.3 standard states that it is enabled by default, so plausibly the model should default to auto-neg being on. If a default was known, then possibly "when" statements would probably be better than a "choice" statement.
I've added "STDS-802-3-YANG@xxxxxxxxxxxxxxxxx". This would be the best place for these comments, but I suspect that you would need to subscribe to be able to post directly (the traffic on the list is pretty light at the moment).
Thanks for the input,